Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

void:triples has page as subject instead of dataset. #177

Open
jeswr opened this issue Feb 8, 2023 · 1 comment
Open

void:triples has page as subject instead of dataset. #177

jeswr opened this issue Feb 8, 2023 · 1 comment

Comments

@jeswr
Copy link

jeswr commented Feb 8, 2023

If we examine the response to https://rdf-play.rubensworks.net/#url=https%3A%2F%2Ffragments.dbpedia.org%2F2016-04%2Fen%3Fpage%3D2; it has the structure

<CONTROLS> {
	<CONTROLS> foaf:primaryTopic <FRAGMENT> .

	<DATASET>
		void:subset <FRAGMENT> ;
		hydra:search [...] ;
	.

	<FRAGMENT> void:subset <PAGE>.

	<PAGE>
		void:triples 1040358853 ;
		hydra:previous <PREVIOUS> ;
		hydra:next <NEXT> ;
	.
}

when really it should be

<CONTROLS> {
	<CONTROLS> foaf:primaryTopic <FRAGMENT> .

	<DATASET>
		void:subset <FRAGMENT> ;
		hydra:search [...] ;
		void:triples 1040358853 ;
	        hydra:totalItems 1040358853 .

	<FRAGMENT> void:subset <PAGE>.

	<PAGE>
		hydra:previous <PREVIOUS> ;
		hydra:next <NEXT> ;
	.
}

Discovered by @langsamu

@rubensworks
Copy link
Member

I think it should even be:

<CONTROLS> {
	<CONTROLS> foaf:primaryTopic <FRAGMENT> .

	<DATASET>
		void:subset <FRAGMENT> ;
		hydra:search [...] .

	<FRAGMENT> void:subset <PAGE>;
		void:triples 1040358853 ;
	        hydra:totalItems 1040358853 .

	<PAGE>
		hydra:previous <PREVIOUS> ;
		hydra:next <NEXT> ;
	.
}

The spec says "In particular, it MUST contain a triple with a void:triples predicate that expresses the estimated total number of matches for the fragment's triple pattern. ".

I think Comunica supports both variants (but not the dataset variant).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants