Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

junit Test output? #120

Open
kknapp1 opened this issue Sep 26, 2024 · 6 comments
Open

junit Test output? #120

kknapp1 opened this issue Sep 26, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@kknapp1
Copy link

kknapp1 commented Sep 26, 2024

Just started using the tool (love it!) and will be using it in our CI pipeline. I'd like to output the test results in junit format (like the Salesforce Scanner tool does). Is anyone else doing that @RubenHalman?

If not junit, how are you using the tool in CI pipelines to give feedback on PR's?
Is anyone aware of another plugin or tool that will convert the json output of lightning-flow-scanner into junit XML (before I go searching)?

@RubenHalman
Copy link
Member

RubenHalman commented Sep 26, 2024

@kknapp1 Thank you for the feedback. As much as I would like to respond, unfortunately I am currently unable to do so.

I would recommend to also consider voting for a ticket to have Lightning Flow Scanner supported as engine in Code Analyzer. low code is still code imo😊

@kknapp1
Copy link
Author

kknapp1 commented Sep 26, 2024

thx for the response @RubenHalman. +1 for including in Code Analyzer - I'll lend my vote to that for sure.

I'll start looking/building a mapping of the json output to junit test results. (i'm not super-familiar w/typescript but maybe even submit a PR if i get something useful to work.)

is the json output generated in this sfdx plugin, or is it generated in the core module? i.e. where would you expect that enhancement to go?

@RubenHalman
Copy link
Member

thx for the response @RubenHalman. +1 for including in Code Analyzer - I'll lend my vote to that for sure.

I'll start looking/building a mapping of the json output to junit test results. (i'm not super-familiar w/typescript but maybe even submit a PR if i get something useful to work.)

is the json output generated in this sfdx plugin, or is it generated in the core module? i.e. where would you expect that enhancement to go?

Thanks, I think @junners or @nvuillam will likely know more on this topic as I do and have a better perspective. My guess would be in the sfdx plugin itself but maybe I am wrong.

@junners
Copy link
Member

junners commented Sep 27, 2024

thx for the response @RubenHalman. +1 for including in Code Analyzer - I'll lend my vote to that for sure.
I'll start looking/building a mapping of the json output to junit test results. (i'm not super-familiar w/typescript but maybe even submit a PR if i get something useful to work.)
is the json output generated in this sfdx plugin, or is it generated in the core module? i.e. where would you expect that enhancement to go?

Thanks, I think @junners or @nvuillam will likely know more on this topic as I do and have a better perspective. My guess would be in the sfdx plugin itself but maybe I am wrong.

Hey @kknapp1 you're absolutely right, it would be in the sfdx module here @RubenHalman's just being modest, he knows the plugin in & out 💯

We had actually thought about doing this too from a while back. We just didn't know if it would stick haha here's a draft of our proposal

@junners
Copy link
Member

junners commented Sep 27, 2024

Coming to think of it. having to support JUNIT would be a good adoption indicator, majority of the git providers know how to read junit results

@junners junners added the enhancement New feature or request label Sep 27, 2024
@nvuillam
Copy link
Collaborator

I think that if a format should be implemented as output... SARIF is the good choice as it is the standard for all SAST Tools :)

It can be facilitated using this library :) https://www.npmjs.com/package/node-sarif-builder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

4 participants