Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment detection on Node.js 18 #10

Open
Xmader opened this issue Mar 27, 2023 · 2 comments
Open

Environment detection on Node.js 18 #10

Xmader opened this issue Mar 27, 2023 · 2 comments

Comments

@Xmader
Copy link
Member

Xmader commented Mar 27, 2023

LibreScore/dl-librescore#16

Node.js 18 added a few browser-compatible APIs, so webmscore could no longer properly detect if it's running in a Node.js environment or browser environment.
@Xmader Xmader mentioned this issue Mar 27, 2023
Closed
@Xmader
Copy link
Member Author

Xmader commented Mar 27, 2023 •
edited
Loading

My local development/test environment is Node.js 16, and the CI runs on Node.js 12.

I should update the CI to test on multiple Node.js versions.

@PeterNjeim
Copy link
Member

PeterNjeim commented Apr 19, 2024 •
edited
Loading

Caused by: nodejs/undici#1857 (comment)

Related: #12, LibreScore/dl-librescore#16

@PeterNjeim PeterNjeim mentioned this issue Apr 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Xmader @PeterNjeim