holesky-test fails in forks

[Inkvi]

I added SIGNER_PRIVATE_KEY and ETHEREUM_RPC env vars to the fork repo but holesky-test always fails.

Here is a failure from the most recent run.

[samlaf]

Hey @Inkvi , really not sure why here, as holesky-test runs are not failing on our side.
Are you sure that this is an issue with the workflow itself, and not with your changes on that PR?

Perhaps (?) this could have to do with the pull_request_target that I added to run the fork tests in our env. This would run the test against the target instead of the source of the PR... which might use a different env in your case? really not sure..

[Inkvi]

@samlaf I specifically checked the workflow against main after syncing with the upstream to eliminate any changes related to my PR.

Additionally, I checked all the recent forks and unfortunately none of them ran or fully set up holesky-test to confirm.

[samlaf]

@Inkvi if you make an upstream PR in our repo with the same code, does the workflow succeed?

[Inkvi]

@Inkvi if you make an upstream PR in our repo with the same code, does the workflow succeed?

I can make a PR to test this idea but my point is that if I run the workflow against main which has only upstream code, it fails.

[samlaf]

Hey @Inkvi you were totally right about pull_request_target being wrong to use. I misunderstood it's behavior. I just merged #196 to change it back to pull_request.

Not sure how this will affect the issue you're having here... perhaps it'll work now? Perhaps it won't... let me know!

[Inkvi]

Hey @samlaf, I synced our fork with the upstream that includes your changes and unfortunately holesky-test failed for main and for a pr again.

[Inkvi]

Maybe the easiest way for you to debug this is to create your own fork and reproduce the issue there.