-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize Date Formats? #90
Comments
hey @jonathansampson Date-normalization is something that should/will be added eventually. I started the library with the intention to add this, but along the way saw that there a few other steps to complete first:
I'm still working on the first 2 steps, so haven't even looked at date formats yet. If you want tackle this, it would be great. This library is used for https://dmns.app and if you check domains there you'll see that dates are not always displayed correctly. Dates are handled with simply doing Also other things I noticed:
|
Thank you for the detailed response. Permit me a possibly silly question, but is it safe to assume a TLD will only ever have a single structure style? For instance, I'm noticing the library doesn't presently parse |
Issued a PR to address this issue in part: #92 |
From what I've seen so far, data structure & format is returned only in a single format by a big chunk of TLDs. There is a standard format that is shared by The problem is with old TLDs, and most notably with country TLDs. After a parser is added, like for |
Description
I'm noticing quite a few different date formats in the returned data. For example,
YYYY.MM.DD
,YYYYMMDD
,YYYY-MM-DD
,YYYY-MM-DDTHH:MM:SSZ
, and more. Would it be worth considering a date-normalization step, aiming to deliver a single format? Or, is there a reason why somebody might wish to preserve the original structure?I took a quick look at several thousand records'
Date Created
, and these were the formats I saw (note: every digit was replaced by0
, full month name byMMMM
, short (3-letter) month name byMMM
, full day name byDDDD
, and short day (3-letter) names byDDD
). The list is sorted by frequency of appearance, most common being at the top.If there's an interest here, I might be able to contribute a PR. I would appreciate any pointers to previous commits which might offer guidance for how best to integrate a feature like this. Thanks!
The text was updated successfully, but these errors were encountered: