You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Pore's data converter does not function properly if given a DataManipulator which is not a VariantData object. Subsequently, it needs to be modified to support all manipulators, and not just ones with a single value.
Case in point: Two of the (presently disabled) block data converter tests for minecraft:log and minecraft:log2 block types fail because AxisData no longer extends VariantData (previously SingleValueData in Data 1.0), so the converter doesn't know how to handle it and simply doesn't, providing an incorrect deabstracted value.
The text was updated successfully, but these errors were encountered:
Pore's data converter does not function properly if given a
DataManipulator
which is not aVariantData
object. Subsequently, it needs to be modified to support all manipulators, and not just ones with a single value.Case in point: Two of the (presently disabled) block data converter tests for
minecraft:log
andminecraft:log2
block types fail becauseAxisData
no longer extendsVariantData
(previouslySingleValueData
in Data 1.0), so the converter doesn't know how to handle it and simply doesn't, providing an incorrect deabstracted value.The text was updated successfully, but these errors were encountered: