Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Data converter doesn't work with DataManipulators which aren't VariantData objects #21

Open
caseif opened this issue Aug 12, 2015 · 0 comments
Assignees

Comments

@caseif
Copy link
Member

caseif commented Aug 12, 2015

Pore's data converter does not function properly if given a DataManipulator which is not a VariantData object. Subsequently, it needs to be modified to support all manipulators, and not just ones with a single value.

Case in point: Two of the (presently disabled) block data converter tests for minecraft:log and minecraft:log2 block types fail because AxisData no longer extends VariantData (previously SingleValueData in Data 1.0), so the converter doesn't know how to handle it and simply doesn't, providing an incorrect deabstracted value.

@caseif caseif self-assigned this Aug 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant