Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null safety for VectorDatabaseWriterProviderRegistry #651

Closed
mukundha opened this issue Oct 26, 2023 · 1 comment
Closed

null safety for VectorDatabaseWriterProviderRegistry #651

mukundha opened this issue Oct 26, 2023 · 1 comment

Comments

@mukundha
Copy link

VectorDatabaseWriterProviderRegistry

think store.createImplementation(configuration); needs to be store.createImplementation(conf);

Map<String, Object> conf = configuration == null ? Map.of() : configuration;
...
...
 return store.createImplementation(configuration);

Issue:

java.lang.NullPointerException: Cannot invoke "Object.toString()" because the return value of "java.util.Map.getOrDefault(Object, Object)" is null
	at ai.langstream.agents.vector.cassandra.CassandraWriter$CassandraVectorDatabaseWriter.lambda$initialise$0(CassandraWriter.java:103)

I also would need to find when the configuration will be null

@eolivelli
Copy link
Member

Fixed with #653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants