Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full support for Pulsar in LangStream #512

Closed
cdbartholomew opened this issue Oct 2, 2023 · 2 comments
Closed

Full support for Pulsar in LangStream #512

cdbartholomew opened this issue Oct 2, 2023 · 2 comments
Assignees

Comments

@cdbartholomew
Copy link
Member

We should be able to use Pulsar as the streaming source for all parts of LangStream.

@eolivelli
Copy link
Member

eolivelli commented Oct 2, 2023

The main things that must work are:

  • schema-less topics or schema = STRING
  • all the standard agents
  • Python code
  • Gateways
  • intermediate topics

this that are to be checked and probably there is something to do:

  • how we handle subscriptions, ids and types
  • message acknowledgments
  • make it work with both Failover, SHARE and KEY_SHARED subscriptions
  • Kafka Connect (this is a big work, @eolivelli has some ideas about how to make it work quite easily)

Notes:

  • DLQ -> we use our DLQ, not Pulsar buillt-in
  • ackTimeout -> disabled !
  • retention, for topics read by the gateways retention must be set by time (because we use the Reader API)

Kafka Connect is "nice-to-have", it is not required to build all the most common pipelines (webcrawler, chatbots...)

@eolivelli eolivelli moved this from Accepted to In Progress in LangStream Oct 17, 2023
@cbornet
Copy link
Member

cbornet commented Oct 20, 2023

Pulsar now works correctly in LangStream.
Remaining work is:

@cbornet cbornet closed this as completed Oct 20, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in LangStream Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants