Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Keep logs in a separate location from config files #57

Open
tukusejssirs opened this issue Mar 15, 2022 · 3 comments
Open

Docker: Keep logs in a separate location from config files #57

tukusejssirs opened this issue Mar 15, 2022 · 3 comments
Milestone

Comments

@tukusejssirs
Copy link
Contributor

I have noticed though that you create driver.log in /etc/fanuc. Could we keep the logs separately from config?

We could use either of the following locations:

  • /etc/fanuc/config for config and /etc/fanuc/logs for logs;
  • /etc/fanuc for config and /var/log/fanuc for logs.
@tukusejssirs
Copy link
Contributor Author

Actually, it might be quite simple to solve this issue:

  1. In nlog.config, we needs to substitute /etc/fanuc with (e.g.) /var/log/fanuc.
  2. Bind some host path to /var/log/fanuc.

The only thing I am not sure whether the path /etc/fanuc for the logs is hardcoded somewhere in fanuc-driver or not.

@MRIIOT
Copy link
Contributor

MRIIOT commented Oct 13, 2022

All logging goes through NLog, so changes inside of nlog.config would affect both application and NLog internal logs. And then another volume mapped to /var/log/fanuc would resolve this.

@MRIIOT MRIIOT added this to the 0.6 milestone Oct 13, 2022
@MRIIOT MRIIOT modified the milestones: 0.6, 0.7 Feb 3, 2023
@MRIIOT MRIIOT modified the milestones: 0.7, 0.8 Sep 5, 2023
@MRIIOT
Copy link
Contributor

MRIIOT commented Sep 5, 2023

https://github.com/Ladder99/fanuc-driver/blob/main/examples/windows/nlog.config

Modify Docker nlog.config and document adding another volume for logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants