Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a TOML addon #1

Open
AntoineChalons opened this issue Apr 9, 2021 · 7 comments
Open

add a TOML addon #1

AntoineChalons opened this issue Apr 9, 2021 · 7 comments

Comments

@AntoineChalons
Copy link

I've recently posted a LV-TOML package and I though it would be great to build an addon for the Open Serializer

@francois-normandin
Copy link
Member

Sure @AntoineChalons!
@rfporter has already mentioned this idea to me. I've seen you've been in touch on LAVAG, so you might already be aware of this.

If you are opened to backsave the LV-TOML to 2013, the OpenSerializer addon can be integrated in this repository along the others.

If you prefer to keep LV-TOML in a later version (totally fine with me), then there are two options:

  1. You can use this repo as a template (fork or copy what you need, including the vipb file, purge it of the other stuff, rename it, etc.) and publish your own OpenSerializer.LV-TOML package under LVOS palette. The LVOS license is 0-BSD, so no attribution required. You copy what you need and you own the modifications.
  2. I can create a new OpenSerializer.LV-TOML repo specifically to host it under LVOS umbrella, and take care of merge requests, publication and long-time maintenance.

If option 2 is of interest to you, ping me on LinkedIn and I can add you as a collaborator on the project! (I've known you for a long time... I'd be happy to extend an invitation)

@francois-normandin
Copy link
Member

Now that I think of it... I think I'll create an open contributor palette under LVOS, so that anyone can put their extensions in there without asking for permission!

@rfporter
Copy link

rfporter commented Apr 9, 2021

If you like, you can take a look at the TOML serializer addon that i made in this fork of serializer addons: https://github.com/rfporter/Serializer.Addons

I abandoned development when I realized that I was moving in the wrong direction and I was considering to build a new toml library from scratch. toml addon doesn't really belong in the serializer addons project. it should be a separate serializer addon.

@francois-normandin
Copy link
Member

At first glance, if the Serializer.INI could be modified to support the more strict-typing of TOML, it could be done without LV-TOML.
I can think of timestamp formatting + cluster and arrays (which differ from NI or OpenG formats which the OpenSerializer.INI is based on)

@AntoineChalons
Copy link
Author

@francois-normandin Back saving to 2013... I won't go that far, my limit absolut limit is 2016 and my easy choice is 2017 because I have a stable VM that I use for open source dev.

Actually just before creating this issue I was going to send you a message on linkedin - changed my mind at the last moment - I've love to get on-board on the LVOS!
So option 2 please.

@rfporter thanks, I'll take a look

@francois-normandin
Copy link
Member

@rfporter
Copy link

I updated the TOML serializer in my fork to use the new version of LV-TOML. Its currently in LV2020 Community Edition. It should be back-saved to LV2017 but I don't currently have that version installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants