-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
if I comment any of those cases - i wouldnt get any warning or something in our ... #1433
Comments
@atherdon the problem was with printMessage, because you have wrapped params into object, but didn't change call of this function |
hmm. I mean, probably there was an issue with my code, but the reason why I created this issue is different. i mean that it's hard to manage items from this array. while we protected our main page - we still don't have a proper way to get an error. Imagine this situation - this generator was used for creating 100 different templates - do you think this structure will be able to handle that? Do you want to explore this issue deeper? |
cc @vadim9999 |
I don't think that the object can cause any errors. switch is not so good, because it's hard to read and understand what is going on. also there are some troubles with switch block, and it's recommended to use object instead |
here i totally agree with you. switch sucks.
ok, let me move this part of our conversation into "improvements.md"
document that I'm still working on.
… Message ID: ***@***.***
com>
|
reactFull: () => generateReactFullTemplate(FULL_SOURCE),
markdown-to-email/src/index.js
Line 14 in 54325ce
The text was updated successfully, but these errors were encountered: