-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module files : explicit load and mnemonic suffixes #984
module files : explicit load and mnemonic suffixes #984
Conversation
…/module_file_explicit_load
@alalazo Sorry for the delayed response. I have not had a chance to test yet but this looks good and addresses the use case I brought up. Are the suffixes meant to help with making the module names more friendly for humans? Thanks. |
@alalazo One potential use case I see for suffixes would be to assign a name to a set of constraints/specs that are common across packages. For example, a package built with the combination of gcc/openmpi/openblas, with respective versions, could be assigned a suffix that would represent that set. That would allow the module names to be parsable by humans while maintaining the hash for guaranteed uniqueness and a check on the reproducibility of the build. |
@alalazo I tested this and it seems to work fine. Thanks. |
@tgamblin If you have time to have a look, I think this is ready to be merged |
@glennpj Sorry for the late reply. For suffixes : your guess is 100% correct. I put that feature in because of the many requests I had internally for some mnemonic suffix to distinguish different variants of a package directly from the module file name. |
@alalazo This is just what I was looking for. We have a package called ROOT that has a builtin C++ parser Cling (based on Clang) that calls gcc to determine where the system headers are located. With this option I can make gcc load when root is loaded. |
@gartung Glad I have been of help! |
…/module_file_explicit_load Conflicts: lib/spack/spack/test/modules.py
@tgamblin done |
@tgamblin The PR is ready to be reviewed |
@alalazo: merged! sorry for the delay. |
* Update dependencies for Circuit Indexer in SpatialIndex Co-authored-by: Pramod Kumbhar <[email protected]>
Modifications
load
to the spec subsection inmodules.yaml
suffixes
to the spec subsection inmodules.yaml
modules.py
Example : explicit load
A configuration file like :
will add the following lines to anything compiled with
[email protected]
:Dotkit will exhibit the same behavior.
Example : mnemonic suffixes
A configuration file like :
will append to any
hdf5
module file the suffixparallel
if+mpi in spec
, producing a module file name like:@glennpj This should address the request for features made here, any feedback is welcome