You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The first thing is more or less easily fixable, but deciding about the right fix is a longer process (linkeddata/rdflib.js#299). But even if we fix it, the client doesn't know whether it is talking to a fixed or a legacy server, and both require different approaches.
The second thing is hard to fix, as code for writing files is spread all over node-solid-server.
Hence, HTTP PATCH is currently not a reliable way forward. As such, I propose to:
apply the patch locally on the client, and update the remote resource through PUT
use the eTag mechanism to ensure we are not overwriting other people's changes
This solution is not ideal because it is inefficient for bandwidth, and will cause performance problems with larger files. However, it avoids file corruption, which is what we are currently risking, and it does not require changes in the client code (which was not broken in the first place).
TL;DR: PATCH is broken on the server, but we cannot easily fix it there; instead of forcing a workaround in clients, we can put that workaround in LDflex.
The text was updated successfully, but these errors were encountered:
We could implement this in LDflex, but disable it by default behind a config option, which could then be enabled automatically when using query-ldflex.
Unfortunately,
PATCH
requests are broken on node-solid server 4.x and 5.x in at least two ways:The first thing is more or less easily fixable, but deciding about the right fix is a longer process (linkeddata/rdflib.js#299). But even if we fix it, the client doesn't know whether it is talking to a fixed or a legacy server, and both require different approaches.
The second thing is hard to fix, as code for writing files is spread all over node-solid-server.
Hence, HTTP
PATCH
is currently not a reliable way forward. As such, I propose to:PUT
This solution is not ideal because it is inefficient for bandwidth, and will cause performance problems with larger files. However, it avoids file corruption, which is what we are currently risking, and it does not require changes in the client code (which was not broken in the first place).
TL;DR:
PATCH
is broken on the server, but we cannot easily fix it there; instead of forcing a workaround in clients, we can put that workaround in LDflex.The text was updated successfully, but these errors were encountered: