Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify the broadcastable type references #265

Closed
exaexa opened this issue Jan 5, 2025 · 6 comments · Fixed by #267
Closed

simplify the broadcastable type references #265

exaexa opened this issue Jan 5, 2025 · 6 comments · Fixed by #267
Labels
⭐✨ Quality ✨⭐ QA, cleaning, testing, CIs

Comments

@exaexa
Copy link
Collaborator

exaexa commented Jan 5, 2025 •
edited
Loading

Having a common supertype, apart from Any, would make this easier. On the other hand I don't see what that could be. SBMLStuff? 😂

Originally posted by @giordano in #264 (comment)
@exaexa
Copy link
Collaborator Author

exaexa commented Jan 5, 2025

from #264 (comment) :

Yeah I thought about that but a "common supertype" is a problem with Julias because you can only have one. So kinda didn't want to waste that space very prematurely. Will think about it.

@exaexa exaexa added the ⭐✨ Quality ✨⭐ QA, cleaning, testing, CIs label Jan 5, 2025
@oxinabox
Copy link

oxinabox commented Jan 6, 2025

SBMLObject would probably make sense.
Cobrapy does this and they call it an Object iirc

@exaexa exaexa mentioned this issue Jan 7, 2025
Merged
@exaexa
Copy link
Collaborator Author

exaexa commented Jan 7, 2025

@oxinabox I think object in pythons is basically the same as Any in Julia, no?

anyway I went to supertypes and it's SBMLObject in the end. Thanks!

@oxinabox
Copy link

oxinabox commented Jan 8, 2025

I am not sure if cobra.Object and just Object is the same thing, esp in Python3.

@exaexa
Copy link
Collaborator Author

exaexa commented Jan 8, 2025 •
edited
Loading

ah wow true, it's object vs Object here, cool stuff. :D

[SNAKEFACE.PNG]

@oxinabox
Copy link

oxinabox commented Jan 8, 2025

cursed language

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⭐✨ Quality ✨⭐ QA, cleaning, testing, CIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

convert the yuge union into a relatively nice supertype match LCSB-BioCore/SBML.jl
2 participants
@exaexa @oxinabox