-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM_data$new error #176
Comments
Hi there, sorry for the trouble. That issue has already been fixed in the beta version 2.1. We hope to release it soon as the next official release. If you’d like to install it now, use this code. Don’t forget to run
I just made a simple test file to verify the fix. Let me know if I didn’t capture your problem in the test and if the beta version doesn’t fix it. |
Dear Dr Neely,
Thank you very much for your answer, the new version works correctly with your example.
However, since I did not get the same RUN results with my dataset than with the previous version, I looked more into it and I noticed some errors in the edited data file when using PM_data$new.
Here are two examples, with the created datafile (named “output” ):
- Ex 1 : one dose administration is created at time 326 also I did not specify dose administration after time 182
- Ex 2 : many doses are created after time 252 also I did not specify any, and some doses administration are missing between time 132 and 252.
Thank you again for the very interesting workshop in Lyon, it was really great !!
Sincerely yours,
Anne Coste
Dr Anne Coste – CCU-AH
Service de maladies infectieuses
CHRU de Brest
Tel : 02 30 33 79 67
De : Michael Neely ***@***.***
Envoyé : jeudi 20 juillet 2023 15:42
À : LAPKB/Pmetrics ***@***.***>
Cc : COSTE ANNE ***@***.***>; Author ***@***.***>
Objet : Re: [LAPKB/Pmetrics] PM_data$new error (Issue #176)
ATTENTION: Cet e-mail provient d’une adresse mail extérieure au CHU de Brest. Ne cliquez pas sur les liens ou n'ouvrez pas les pièces jointes à moins de connaître l'expéditeur et de savoir que le contenu est sûr. Cliquez ici<https://www.mailcontrol.com/sr/Gdc8on_5CvzGX2PQPOmvUt_pSVNK13NsMWf9j1ndsocTmuyK0knEuhK02b8BujA4--IQ3lHAulsoKRuEdgZyEA==> si vous considérez ce mail comme étant un spam. Merci de votre vigilance.
Hi there, sorry for the trouble. That issue has already been fixed in the beta version 2.1. We hope to release it soon as the next official release. If you’d like to install it now, use this code. Don’t forget to run PMbuild() again.
***@***.***”)
I just made a simple test file to verify the fix. Let me know if I didn’t capture your problem in the test and if the beta version doesn’t fix it.
test.csv<https://github.com/LAPKB/Pmetrics/files/12109602/test.csv>
—
Reply to this email directly, view it on GitHub<#176 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BBMUQA2J6M3AHQ7ZUOLUJ7DXREYRLANCNFSM6AAAAAA2RH4REM>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
Can you email me your data file so we can figure out what’s wrong? You can send to [email protected]. I won’t share it outside our group. We just need it for debugging purposes. Thanks. |
Dear Dr Neely,
I am sorry to bother you again. I downloaded the latest version today and tried again but it still doesn't work.
Could you please give me a link to download legacy pmetrics? I really need to work and make progress on my PhD.
Thank you again for the wonderful workshop in Lyon!
Sincerely yours,
Anne Coste
Envoyé à partir de Outlook pour Android<https://aka.ms/AAb9ysg>
…________________________________
From: Michael Neely ***@***.***>
Sent: Thursday, July 27, 2023 3:39:15 PM
To: LAPKB/Pmetrics ***@***.***>
Cc: AnneCoste ***@***.***>; Author ***@***.***>
Subject: Re: [LAPKB/Pmetrics] PM_data$new error (Issue #176)
ATTENTION: Cet e-mail provient d’une adresse mail extérieure au CHU de Brest. Ne cliquez pas sur les liens ou n'ouvrez pas les pièces jointes à moins de connaître l'expéditeur et de savoir que le contenu est sûr. Cliquez ici<https://www.mailcontrol.com/sr/-sNcfXLgv-rGX2PQPOmvUiQSa3-T5MHvuyrnP0wcLzpcaIwMuvv3dvLkeYGQkWyE5DxgNB-gjFDJaydNu2tBwg==> si vous considérez ce mail comme étant un spam. Merci de votre vigilance.
Can you email me your data file so we can figure out what’s wrong? You can send to ***@***.******@***.***>. I won’t share it outside our group. We just need it for debugging purposes. Thanks.
—
Reply to this email directly, view it on GitHub<#176 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BBMUQAY5RZQNC7SASDEXHDDXSJVQHANCNFSM6AAAAAA2RH4REM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Hi Anne, Older versions are available on the releases page : https://github.com/LAPKB/Pmetrics/releases?page=1 Ronan |
@AnneCoste, were you able to download a previous version that worked for you? |
Oh, I'm so sorry. This one got away from me. I just fixed the bug I believe. Can you try version 2.1.1 in the dev branch?
|
Hello,
A data file used for Legacy Pmetrics is not valid for Pmetrics v2, despite using PM_data$new. In the datafile, some additional doses in an EVID=1 row overlap with the timing of an EVID=0. I get a warning reporting unsorted times. ADDL>0 rows are expanded but the unsorted times fail to be sorted and the error file is not edited.
In the datafile, both oral and IV route exist.
Is there a solution to this problem, without expanding manually all additionnal doses ?
Thank you very much for your attention and for your help.
The text was updated successfully, but these errors were encountered: