Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM_data$new error #176

Open
AnneCoste opened this issue Jul 20, 2023 · 7 comments
Open

PM_data$new error #176

AnneCoste opened this issue Jul 20, 2023 · 7 comments

Comments

@AnneCoste
Copy link

Hello,
A data file used for Legacy Pmetrics is not valid for Pmetrics v2, despite using PM_data$new. In the datafile, some additional doses in an EVID=1 row overlap with the timing of an EVID=0. I get a warning reporting unsorted times. ADDL>0 rows are expanded but the unsorted times fail to be sorted and the error file is not edited.
In the datafile, both oral and IV route exist.
Is there a solution to this problem, without expanding manually all additionnal doses ?
Thank you very much for your attention and for your help.

@mnneely
Copy link
Contributor

mnneely commented Jul 20, 2023

Hi there, sorry for the trouble. That issue has already been fixed in the beta version 2.1. We hope to release it soon as the next official release. If you’d like to install it now, use this code. Don’t forget to run PMbuild() again.

devtools::install_github(“LAPKB/Pmetrics@dev”)

I just made a simple test file to verify the fix. Let me know if I didn’t capture your problem in the test and if the beta version doesn’t fix it.

test.csv

@AnneCoste
Copy link
Author

AnneCoste commented Jul 27, 2023 via email

@mnneely
Copy link
Contributor

mnneely commented Jul 27, 2023

Can you email me your data file so we can figure out what’s wrong? You can send to [email protected]. I won’t share it outside our group. We just need it for debugging purposes. Thanks.

@AnneCoste
Copy link
Author

AnneCoste commented Sep 26, 2023 via email

@Trepon
Copy link

Trepon commented Sep 26, 2023

Hi Anne,

Older versions are available on the releases page : https://github.com/LAPKB/Pmetrics/releases?page=1

Ronan

@mhovd
Copy link
Contributor

mhovd commented Oct 11, 2023

@AnneCoste, were you able to download a previous version that worked for you?
Or do you need any help with manual expansion of the doses, if the current solution does not work?

@mnneely
Copy link
Contributor

mnneely commented Oct 11, 2023

Oh, I'm so sorry. This one got away from me. I just fixed the bug I believe. Can you try version 2.1.1 in the dev branch?

devtools::install_github("LAPKB/Pmetrics@dev")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants