Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication] Delete folder in starting communication is not working in many occasions, simulation gets stuck #346

Open
loumalouomega opened this issue Feb 21, 2023 · 12 comments

Comments

@loumalouomega
Copy link
Member

In line:

fs::remove_all(mCommFolder, ec);

I assume you are aware, but many times the simulation gets stuck because this remove folder fails and instead of an error a message is thrown, maybe is a good idea to make this an actual error. I prefer to get an error that get stuck ad infinitum. Furthermore, I am solving the problem locally, removing the folder before the simulation starts, so there is no conflict of permissions/lecture/reading/etc...

@philbucher
Copy link
Member

Hm this has not happened to me yet

Which OS?

@loumalouomega
Copy link
Member Author

More in windows than Linux, but also happened to me in Linux

@philbucher
Copy link
Member

I had plenty of similar issues, but never this particular one
Snd I tested it extensively under different systems
Do you know about others having the same problem or is it just you?

I need to think about this 🤔

(Btw you can disable the comm in folder)

@loumalouomega
Copy link
Member Author

I am just informing, we solved the problem locally

@philbucher
Copy link
Member

How?

@loumalouomega
Copy link
Member Author

Removing the folder before invoking the simulation, so no permissions conflict

@philbucher
Copy link
Member

Ah so it is a permissions issue?

@loumalouomega
Copy link
Member Author

Ah so it is a permissions issue?

Yes:

Furthermore, I am solving the problem locally, removing the folder before the simulation starts, so there is no conflict of permissions/lecture/reading/etc...

@philbucher
Copy link
Member

Sorry didn't understand exactly

Can you please describe the different errors in more detail?

You say it hangs, but permission issues usually throw

@loumalouomega
Copy link
Member Author

The message of error removing the folder appears, then it gets stuck. That's why I recommend changing the message for an error message instead.

@philbucher
Copy link
Member

Does the primary side (the one that does the folder stuff) get stuck or the other one?

@loumalouomega
Copy link
Member Author

The primary side is stuck because the secondary gets stuck. The primary just throws a warning, that's why I recommend changing the warning for an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants