Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting all downloaded chapters doesn't reduce disk usage to 0B. #1226

Open
2 tasks done
MariusAlbrecht opened this issue Dec 26, 2024 · 0 comments
Open
2 tasks done
Labels
bug Something isn't working

Comments

@MariusAlbrecht
Copy link
Contributor

MariusAlbrecht commented Dec 26, 2024

Brief summary

When downloading chapters kotatsu creates index.json and cover.* (one of multiple image formats) metadata files alongside the *.cbz files representing the actual chapters. These do not get deleted when the user deletes all downloaded chapters through the app and can only be removed manually using a file management app. I expect the app to clean up those files, especially when their disk usage is shown in the UI.

I think deleting them when the last downloaded chapter gets deleted is best.
An alternative would be to just add a button and let people do it manually in the app. That button could be placed in the "Saved manga" popup next to the "Delete read chapters" button:
Screenshot_2024-12-26-23-46-39-39_a5af3585a93e2016f6667aaf7e1e2f32

Steps to reproduce

  1. download a chapter
  2. delete it again
  3. see a few kB of disk usage in the app
  4. see cover image and index json files in the respective directory

Kotatsu version

7.7.4

Android version

12

Device

OnePlus 7 Pro

Acknowledgements

  • This is not a duplicate of an existing issue. Please look through the list of open issues before creating a new one.
  • This is not an issue with a specific manga source. Otherwise, you have to open an issue in the parsers repository.
@MariusAlbrecht MariusAlbrecht added the bug Something isn't working label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant