Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out which logging package to use and replace already used logrus with it #48

Open
pmalek opened this issue Aug 11, 2022 · 3 comments

Comments

@pmalek
Copy link
Member

pmalek commented Aug 11, 2022

As of now, we're using logrus as logging package of choice.

As of now it's in maintenance mode.

This issue track an effort to come up with one particular logging package that we can use as a replacement for logrus and use that instead.

@programmer04
Copy link
Member

I can recommend zerolog I used it in a quite big app and liked it

@pmalek
Copy link
Member Author

pmalek commented May 8, 2023

Apart from logrus being in maintenance mode this issue also tries to capture a higher level problem which is proliferation of different logging packages being used throughout KIC, KGO and other repos (including this one).

There's also a thread on slack and this long standing issue in KIC: Kong/kubernetes-ingress-controller#1893. Ideally we'd pick one interface which would be used throughout all our projects

@programmer04
Copy link
Member

Other projects (KGO and KIC) use

github.com/go-logr/logr
github.com/go-logr/zapr

hence KTF should use them too.

Moreover, in case of errors, they should be rather returned explicitly to handle by caller than log it directly in this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants