Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaufrette FTP defaults to FTP_BINARY, but Bundle defaults to FTP_ASCII #107

Open
Richtermeister opened this issue Jan 28, 2015 · 2 comments
Assignees
Milestone

Comments

@Richtermeister
Copy link

There is an inconsistency in the default values between the library and bundle:

Bundle - FTP_ASCII
https://github.com/KnpLabs/KnpGaufretteBundle/blob/master/DependencyInjection/Factory/FtpAdapterFactory.php#L52

Library - FTP_BINARY
https://github.com/KnpLabs/Gaufrette/blob/master/src/Gaufrette/Adapter/Ftp.php#L48

Not sure that the bundle needs to specify a default, but give that it's been this way it's probably too big of a BC to fix now. Just reporting this for the next major release.

@akovalyov
Copy link
Contributor

@Richtermeister I am sorry to come to you too late about it. I am including this issue into the 0.4 milestone.

@akovalyov akovalyov added this to the 0.4 milestone Jan 16, 2016
@Richtermeister
Copy link
Author

@akovalyov Awesome, thank you!

@PedroTroller PedroTroller self-assigned this Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants