Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optipng causes entire plugin to fail silently #95

Open
psabharwal123 opened this issue Aug 31, 2019 · 2 comments
Open

optipng causes entire plugin to fail silently #95

psabharwal123 opened this issue Aug 31, 2019 · 2 comments

Comments

@psabharwal123
Copy link

passing any value for optipng causes entire plugin to fail silently and none of the files are compressed. it would be good to add some tests to this project.

@Klathmon
Copy link
Owner

Klathmon commented Aug 31, 2019

I'd gladly accept a PR with tests!

But I can't reproduce the optipng issues. Can you post a config?

FYI: I live in florida and am preparing for a hurricane, so I most likely won't be around to work on this project for the next week or so, possibly longer.

@psabharwal123
Copy link
Author

Thanks, np, I ll post it shortly. I ran it a few times and it seems some of the images are being optimized (sometimes none of them). Should it use webpack to emit the files instead of writing them directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants