Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are some major ui changes needed #1

Open
DevItaliya22 opened this issue Nov 16, 2024 · 4 comments
Open

There are some major ui changes needed #1

DevItaliya22 opened this issue Nov 16, 2024 · 4 comments
Assignees

Comments

@DevItaliya22
Copy link

There are some major UI changes needed , the first page itself have some bugs
image
like here invalid room id is there still error is something else etc , there are some more bugs , can create PR if needed

@DevItaliya22
Copy link
Author

Overall work is too good , like the worker code and websocket code is looking nice and it ws very easy and fast to set it up locally with in 3-4 mins .

@KishanVyas308
Copy link
Owner

KishanVyas308 commented Nov 17, 2024

Hi @DevItaliya22,

Thank you for bringing these UI issues to my attention. I appreciate your detailed feedback and the screenshot provided.

  • The issue with the invalid room ID and the irrelevant error message is noted.
  • If you have identified any other bugs, please share them here.
  • Also feel free to create a pull request with the necessary changes.

Your contributions are welcome and highly appreciated. Thank you for your help in improving the real-time collaborative code editor.

@KishanVyas308
Copy link
Owner

BTW, If you would like to create a pull request to address these bugs, I would be happy to assign this issue to you.

@KishanVyas308
Copy link
Owner

Overall work is too good , like the worker code and websocket code is looking nice and it ws very easy and fast to set it up locally with in 3-4 mins .

Thank you for your positive feedback! I'm happy to hear that you found the worker code and websocket code well-implemented and that you were able to set it up locally quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants