Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible false positive 08608 #9164

Open
ziga-lunarg opened this issue Jan 7, 2025 · 1 comment
Open

Possible false positive 08608 #9164

ziga-lunarg opened this issue Jan 7, 2025 · 1 comment
Labels
Bug Something isn't working

Comments

@ziga-lunarg
Copy link
Contributor

VUID-vkCmdDraw-None-08608

If a pipeline is bound to the pipeline bind point used by this command, there must not have been any calls to dynamic state setting commands for any state specified statically in the VkPipeline object bound to the pipeline bind point used by this command, since that pipeline was bound

If a pipeline doesn't use tessellation, is it valid to call vkCmdSetPatchControlPointsEXT() after the pipeline is bound?

TEST_F(PositivePipeline, SetUnrelatedDynamicStateAfterBind) {
    TEST_DESCRIPTION("Set vkCmdSetPatchControlPointsEXT after pipeline is bound that does not use tessellation");

    AddRequiredExtensions(VK_EXT_EXTENDED_DYNAMIC_STATE_2_EXTENSION_NAME);
    AddRequiredFeature(vkt::Feature::extendedDynamicState2PatchControlPoints);
    RETURN_IF_SKIP(Init());
    InitRenderTarget();

    CreatePipelineHelper pipe(*this);
    pipe.CreateGraphicsPipeline();

    m_command_buffer.Begin();
    m_command_buffer.BeginRenderPass(m_renderPassBeginInfo);
    vk::CmdBindPipeline(m_command_buffer.handle(), VK_PIPELINE_BIND_POINT_GRAPHICS, pipe.Handle());
    vk::CmdSetPatchControlPointsEXT(m_command_buffer.handle(), 4u);
    vk::CmdDraw(m_command_buffer.handle(), 3u, 1u, 0u, 0u);
    m_command_buffer.EndRenderPass();
    m_command_buffer.End();
}
@ziga-lunarg ziga-lunarg added the Bug Something isn't working label Jan 7, 2025
@spencer-lunarg
Copy link
Contributor

this is related to #7858 (https://gitlab.khronos.org/vulkan/vulkan/-/issues/3868)

basically we need to get a spec clarification (now that we seem to have so much CTS coverage) to show that dynamic state can be "ignored" if not used for certain parts of the pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants