-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditionally test fallback/secondary queue via SYCL_CTS_ENABLE_DEPRECATED_FEATURES_TESTS #933
Comments
This PR only deprecates APIs, so those APIs are still supported. Any CTS tests we have for these APIs should remain. |
Although we may want to wrap the corresponding tests in |
Why do we have an option to skip testing of deprecated APIs? Presumably, this option is not used for conformance since deprecated APIs are still part of the specification. |
|
Thanks. I reopened this issue and changed the title to describe the problem. |
This issue was opened as a result of KhronosGroup/SYCL-Docs#615.
The CTS has an existing option
SYCL_CTS_ENABLE_DEPRECATED_FEATURES_TESTS
which enables / disables testing of deprecated features. Because KhronosGroup/SYCL-Docs#615 deprecates some features in SYCL-Next, we should conditionally test these features in SYCL-Next only when that option is enabled.This opens a general question about how to handle
SYCL_CTS_ENABLE_DEPRECATED_FEATURES_TESTS
with a unified CTS. Some features (like the secondary queue) are deprecated only in SYCL-Next. Presumably, we want these features to be unconditionally tested when running the CTS in SYCL 2020 mode. However, when running the CTS in SYL-Next mode, they should be tested only whenSYCL_CTS_ENABLE_DEPRECATED_FEATURES_TESTS
is enabled.Alternatively, we could decide that
SYCL_CTS_ENABLE_DEPRECATED_FEATURES_TESTS
is no longer needed, and we could remove that option from the CTS. Since deprecated features are still required by the specification, this option can't be used for conformance submissions anyway.The text was updated successfully, but these errors were encountered: