Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate inline CSS styles best practices to this repo #50

Open
kevinbarabash opened this issue Jan 19, 2016 · 6 comments
Open

migrate inline CSS styles best practices to this repo #50

kevinbarabash opened this issue Jan 19, 2016 · 6 comments

Comments

@kevinbarabash
Copy link
Contributor

That way everything regarding styles/best practices in the same place.

@csilvers
Copy link
Member

Sorry, what's "in-line styles best practices"?

@kevinbarabash
Copy link
Contributor Author

It's a Google doc that Emily created a while back.

@csilvers
Copy link
Member

Ah! I understand now -- you're referring to CSS styles.

@xymostech are you interested in making a pull request for this?

@kevinbarabash kevinbarabash changed the title migrate in-line styles best practices to this repo migrate inline CSS styles best practices to this repo Jan 19, 2016
@kevinbarabash
Copy link
Contributor Author

I can create a pull request for this too since it'll probably be copy/paste + formatting changes. The reason why I opened an issue is that I wanted to get a sense of whether other people thought this was worth doing.

@csilvers
Copy link
Member

I'll let @xymostech have final say, as the author of the original doc.

@xymostech
Copy link
Contributor

We talked about this, I already had them written up somewhere and kevin's gonna make sure they look good and send a pull request. I think the main reason we used a google doc instead of here was to allow commenting, this sounds good for a long term solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants