Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENHANCEMENT: Make default email guessing more intelligent #1

Open
mroth opened this issue Jun 17, 2015 · 0 comments
Open

ENHANCEMENT: Make default email guessing more intelligent #1

mroth opened this issue Jun 17, 2015 · 0 comments

Comments

@mroth
Copy link
Contributor

mroth commented Jun 17, 2015

Currently, if kaclone.email if not present in the gitconfig hierarchy, we try to guess default user email by doing $USER + "@" + DEFAULT_EMAIL_DOMAIN.

As @spicyj noted in code review, we could additionally first check if gitconfig has a user.email setting which endswith(DEFAULT_EMAIL_DOMAIN), and if so, use that first. There are a few more places we could check for hints as well, such as the GIT_AUTHOR_EMAIL os.environ variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant