Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands can't be used without kdyby/console #14

Open
vojtech-dobes opened this issue Jan 4, 2015 · 3 comments
Open

Commands can't be used without kdyby/console #14

vojtech-dobes opened this issue Jan 4, 2015 · 3 comments
Labels

Comments

@vojtech-dobes
Copy link

Because you depend on @inject annotation, commands from this package can't be used without kdyby/console, even though it shouldn't be problem. Would you consider making them independent on kdyby/console?

@vojtech-dobes
Copy link
Author

The reason why I don't want to use kdyby/console is because it depends on nette/application, which I don't need.

@fprochazka
Copy link
Member

Yeah, we could do that.

You know you can be using injects on the commands, if you just put them together to the console in DI Container, even without kdyby/console :)

Anyway, this should be implemented using the console helpers. I definitely wouldn't recomend passing the deps in command constructors.

@fprochazka fprochazka added the bug label May 20, 2017
@fprochazka
Copy link
Member

Kdyby/Console now works without nette/application. But this should be solved anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants