-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future? #97
Comments
I disagree. This is a different case. In Symfony it's in DoctrineBridge which integrates doctrine packages into various symfony components - in this case EventManager to symfony/dependency-injection. The important note here is that DoctrineBridge only depends on doctrine/common, so unless you want to do the same with Kdyby/Doctrine it does not belong there in my opinion. As for EventDispatcher I'm currently writing my own integration to Nette (almost done). I didn't like a few things in Symnedi/EventDispatcher (no ContainerAwareEventDispatcher, no tag for subscribers) and didn't want to BC break it so I'll deprecate it instead with a new package. Otherwise I agree that mixing the event mechanisms is wrong. That is why I'm trying to get rid of Kdyby/Events completely in my application. What I'm aiming for is to use:
|
It could be moved to a separate package, that's a detail. My point is, that it's IMHO needed anyway and it could simplify Kdyby/Events. |
I agree. I didn't do that because I actually used the ContainerAwareEventManager from symfony/doctrine-bridge and connected it to Nette/DI using ContainerAdapter. If I implemented a ContainerAwareEventManager which would work with Same goes for EventDispatcher - for now I'll use ContainerAwareEventDispatcher from symfony + the mentioned ContainerAdapter. |
Here is my integration of EventDispatcher: https://github.com/Arachne/EventDispatcher And I decided to put the EventManager in a separate package as well: https://github.com/Arachne/EventManager Both packages are implemented to be as simple as possible. |
So, the future:
|
I have the following idea:
kdyby/events-nette
?)The thing is, I don't think mixing the event mechanisms is a good idea anymore. I think you should be able to use both systems independently, without collisions.
What do you guys think?
The text was updated successfully, but these errors were encountered: