Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow filtering for --exportTo #524

Open
GitMensch opened this issue Oct 12, 2023 · 2 comments
Open

allow filtering for --exportTo #524

GitMensch opened this issue Oct 12, 2023 · 2 comments

Comments

@GitMensch
Copy link
Contributor

Is your feature request related to a problem? Please describe.
After running system-wide recordings (actually limited to a service user already) I often get huge amount of warning messages like "Invalid memory read requested by dwf" and "failed to attach state Couldn't find architecture of any ELF", "No DWARF information found 2", "No DWARF information found 5" during open/export.

Then I'm in Hotspot seeing a lot of processes I'm not interested in at all (bash, grep, ls, and others), so I need to always filter when inspecting the recording.

Describe the solution you'd like
Provide an option to filter when converting to perfparser file like it is possible in the timeline view ([list of] name/pid).
It may be possible to skip several things then, that not match the filter during import, possibly also reducing the amount of warning messages (for example adding a filter "only processes that contain myApp") - but in any case the .perfparser output file would be much smaller, could be opened faster in Hotspot, would not need the filter to be post-applied each time it is opened.

@milianw
Copy link
Member

milianw commented Oct 13, 2023

While possible, this would require special code as the current filtering is applied to the analyzed hotspot specific data, not the raw perfparser data. Meaning this isn't that trivial to implement.

@GitMensch
Copy link
Contributor Author

More details: the following entries of perf report come to mind, providing the same (in perfparser first, then only forward for --exportTo, right?) would be very helpful

       -d, --dsos=
           Only consider symbols in these dsos. CSV that understands file://filename entries. This option will affect
           the percentage of the overhead column. See --percentage for more info.

       -S, --symbols=
           Only consider these symbols. CSV that understands file://filename entries. This option will affect the
           percentage of the overhead column. See --percentage for more info.

       --symbol-filter=
           Only show symbols that match (partially) with this filter.

The use case is the option to have one big perf recording (for example from user-wide recording or from a recoding that has many sub-processes) and limiting it to the interesting parts and/or to split that into several smaller perfparser files that hotspot will handle quick later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants