You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the FunctionmemorySize property has an inconsistent type between the data model and the AWS integration. In the data-model, the type is listed as a "string" and in the AWS integration, the data type is a "number". Additionally, it's unclear from the name of the property what the memory unit is (e.g. mb, gb, etc.).
Proposal
Change the data type to a number
Rename the property to have unit clarity. I think we should standardize on a memory unit size to make it clear in the property name and description fields what the unit is. Google Cloud makes the property name very distinct: availableMemoryMb. Thoughts on updating the property field to match Google Cloud?
The text was updated successfully, but these errors were encountered:
I think using number is absolutely the way to go to support math, and I think availableMemoryMb is an excellent name, assuming memorySize isn't an AWS name that we could stick with but move to memorySizeMb.
This proposal will require:
Add new property, keeping old one for now
Find all saved/managed queries that use memorySize and change to use availableMemoryMb
See: https://github.com/JupiterOne/data-model/blob/master/src/schemas/Function.json#L24
Problem
Currently, the
Function
memorySize
property has an inconsistent type between the data model and the AWS integration. In the data-model, the type is listed as a "string" and in the AWS integration, the data type is a "number". Additionally, it's unclear from the name of the property what the memory unit is (e.g. mb, gb, etc.).Proposal
number
description
fields what the unit is. Google Cloud makes the property name very distinct:availableMemoryMb
. Thoughts on updating the property field to match Google Cloud?The text was updated successfully, but these errors were encountered: