Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More tests #13

Closed
christopher-dG opened this issue Sep 25, 2019 · 1 comment
Closed

More tests #13

christopher-dG opened this issue Sep 25, 2019 · 1 comment

Comments

@christopher-dG
Copy link
Member

The test suite for this package is really lacking. Much of that is due to its dependence on HTTP responses, so we should mock those bits out with SimpleMock.

Pagination definitely needs a good test suite since the logic is pretty finicky.
@christopher-dG
Copy link
Member Author

Tests mentioned in #22, but we won't be using SimpleMock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@christopher-dG