Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyObject use numpy_ma.array to plot masked missings #596

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deszoeke
Copy link

fixes #593
tests to be added later

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 22.13%. Comparing base (343cec5) to head (9792c98).

Files with missing lines Patch % Lines
src/PyPlot.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
- Coverage   22.31%   22.13%   -0.19%     
==========================================
  Files           4        4              
  Lines         363      366       +3     
==========================================
  Hits           81       81              
- Misses        282      285       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alexander-Barth
Copy link

Thank you, @deszoeke, for making the PR :-)

if you need a (trivial) test:

using Test
@test PyObject([1,missing]).mask[2]

@deszoeke
Copy link
Author

Automatic checks fail (on ubuntu and windows) because fragile PyCall builds fail.

@Alexander-Barth wrote:

if you need a (trivial) test:

using Test
@test PyObject([1,missing]).mask[2]

Testing of PyPlot is quite minimal. PR deszoeke:patch-2 adds a test of plot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

julia PyPlot support missing data
3 participants