Update to [email protected]

[odow]

• Needs a test, but should close SegFault for BlockElimination #65

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.99%. Comparing base (c22506b) to head (ceca648).

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   85.88%   85.99%   +0.10%     
==========================================
  Files          12       12              
  Lines         914      914              
==========================================
+ Hits          785      786       +1     
+ Misses        129      128       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[odow]

@blegat, so this doesn't segfault anymore, but it does throw:

julia> poly_out = eliminate(poly_in, collect(1:4), BlockElimination())
ERROR: ddf_BlockElimination returned a NULL pointer but did not provide any error. Please report this by opening an issue at https://github.com/JuliaPolyhedra/CDDLib.jl.
Stacktrace:
 [1] error(s::String)
   @ Base ./error.jl:35
 [2] myerror
   @ ~/.julia/dev/CDDLib/src/error.jl:31 [inlined]
 [3] macro expansion
   @ ~/.julia/dev/CDDLib/src/ccall.jl:30 [inlined]
 [4] dd_blockelimination(matrix::Ptr{CDDLib.Cdd_MatrixData{Float64}}, delset::Ptr{UInt64})
   @ CDDLib ~/.julia/dev/CDDLib/src/operations.jl:311
 [5] blockelimination(matrix::CDDInequalityMatrix{Float64, Float64}, delset::Vector{Int64})
   @ CDDLib ~/.julia/dev/CDDLib/src/operations.jl:334
 [6] eliminate(p::CDDLib.Polyhedron{Float64}, delset::Vector{Int64}, ::BlockElimination)
   @ CDDLib ~/.julia/dev/CDDLib/src/polyhedron.jl:182
 [7] top-level scope
   @ REPL[10]:1

[blegat]

Thanks!

[schillic]

This change has not been released yet. Is that intentional?

[blegat]

Just an oversight, done now ;)