Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taking preprocess seriously #45

Open
PhilipVinc opened this issue Sep 25, 2019 · 0 comments
Open

Taking preprocess seriously #45

PhilipVinc opened this issue Sep 25, 2019 · 0 comments

Comments

@PhilipVinc
Copy link
Member

PhilipVinc commented Sep 25, 2019

Right now the method that one needs to implement to extend TBLogger for his own custom types is preprocess(tag, value, data) and it modifies the data argument.

I find this confusing. It would be more Julian if it was defined as

preprocess!(data, tag, value)

And maybe even the preprocess! could be changed to something that is more clear.
As adding the ! would change the function name, this technically would just be a deprecation and not a breaking change, so it should not be a big issue for a v0.2.

@PhilipVinc PhilipVinc changed the title Taking precompute seriously Taking preprocess seriously Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant