You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now the method that one needs to implement to extend TBLogger for his own custom types is preprocess(tag, value, data) and it modifies the data argument.
I find this confusing. It would be more Julian if it was defined as
preprocess!(data, tag, value)
And maybe even the preprocess! could be changed to something that is more clear.
As adding the ! would change the function name, this technically would just be a deprecation and not a breaking change, so it should not be a big issue for a v0.2.
The text was updated successfully, but these errors were encountered:
PhilipVinc
changed the title
Taking precompute seriously
Taking preprocess seriously
Sep 28, 2019
Right now the method that one needs to implement to extend
TBLogger
for his own custom types ispreprocess(tag, value, data)
and it modifies thedata
argument.I find this confusing. It would be more Julian if it was defined as
And maybe even the
preprocess!
could be changed to something that is more clear.As adding the
!
would change the function name, this technically would just be a deprecation and not a breaking change, so it should not be a big issue for av0.2
.The text was updated successfully, but these errors were encountered: