Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: targets.docs.deps and targets.benchmark.deps #521

Closed
tkf opened this issue Jul 22, 2018 · 2 comments
Closed

Feature request: targets.docs.deps and targets.benchmark.deps #521

tkf opened this issue Jul 22, 2018 · 2 comments

Comments

@tkf
Copy link
Member

tkf commented Jul 22, 2018

It would be nice to have targets.docs.deps and targets.benchmark.deps, etc. (or docs/Project.toml and benchmark/Project.toml somehow stacked on top of the root Project.toml) for document- and benchmark- specific dependencies. Are you planning to add such features?

It may be related to #480 since I guess those features will share the implementation.

@tkf tkf closed this as completed Aug 4, 2018
@StefanKarpinski
Copy link
Member

StefanKarpinski commented Aug 4, 2018

You can add these deps to [extras] and then have targets.banchmark = [...] to list the packages you want in this target. What do you imagine that this target would mean to the package manager?

@tkf
Copy link
Member Author

tkf commented Aug 4, 2018

Yes, I saw you wrote #531 so I thought it was solved and closed it (probably should have commented that).

What do you imagine that this target would mean to the package manager?

I thought the best answer would be nothing in the sense that the environments for ./docs, ./benchmark and ./test are yet another environment with extra packages on top of [deps] and the package manager doesn't care what it's for. From what I understand from the PR, it looks like your design of [extras] and [targets] covers arbitrary targets so that looks great. What is not clear for me at the moment is the way to activate one of [targets] (as already mentioned in #480 (comment)) but I suppose that's more like julia issue? Ideally, I'd like to do something like pkg> activate @:docs in REPL or julia --project=@:docs docs/make.jl from shell to activate docs target in current project @ (completely made-up syntax).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants