Use dynamic libstdc++ selection only on Linux #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bgeihe Could you please confirm that this PR still works on your system with the newer libstdc++? |
Codecov Report
@@ Coverage Diff @@
## master #869 +/- ##
==========================================
- Coverage 84.94% 84.26% -0.68%
==========================================
Files 3 3
Lines 797 801 +4
==========================================
- Hits 677 675 -2
- Misses 120 126 +6
|
|
Confirmed! |
|
All CI issues seem to be unrelated. I am merging this even though we do not have a single test passing on Julia v1.9 (again, unrelated failures it seems), since it is a major issue for many Windows users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #853, we introduced the ability to bundle the libstdc++ library that is actually loaded by Julia with a library/app bundle. Before, it was hardcoded to use always the Julia-provided libstdc++ library, which did not work on Linux platforms that had a local system-provided libstdc++ newer than the Julia-provided one.
However, the solution implemented in #853 caused PackageCompiler.jl to not work anymore for Windows users without administrator privileges. This PR remedies this by making the dynamic libstdc++ selection only run on Linux, just like it is done in Julia itself.
Resolves #866.