Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all message types in jlkernel #4

Closed
13 of 17 tasks
stevengj opened this issue Jul 24, 2013 · 5 comments
Closed
13 of 17 tasks

Support all message types in jlkernel #4

stevengj opened this issue Jul 24, 2013 · 5 comments

Comments

@stevengj
Copy link
Member

Currently, we only (barely) support execute_request and the corresponding replies. We need to support all of the IPython message types:

stevengj added a commit that referenced this issue Jul 24, 2013
stevengj added a commit that referenced this issue Jul 25, 2013
stevengj added a commit that referenced this issue Jul 25, 2013
stevengj added a commit that referenced this issue Jul 25, 2013
@stevengj
Copy link
Member Author

commit 4d06e66 adds a crash message when we catch an unexpected exception, but IPython doesn't seem to respond to it. I must be doing something wrong. @fperez?

@minrk
Copy link
Contributor

minrk commented Jul 25, 2013

Unrecognized message types generally do not have any effect in frontends. If anything, they typically just produce a warning.

@stevengj
Copy link
Member Author

@minrk, I'm confused: IPython's front ends don't recognize the (documented) crash message?

stevengj added a commit that referenced this issue Jul 25, 2013
@minrk
Copy link
Contributor

minrk commented Jul 25, 2013

Arg! No - there are a couple of message types in the spec that belong in the 'unimplemented future ideas' section. Those are get/setattr and crash. I will make sure that my wire-protocol doc PR fully updates the message spec doc to reflect reality.

@stevengj
Copy link
Member Author

Basically done except for #42 and #47, so I'm closing this meta-issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants