Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken truncated tarball tests #108

Open
StefanKarpinski opened this issue Apr 23, 2021 · 0 comments
Open

fix broken truncated tarball tests #108

StefanKarpinski opened this issue Apr 23, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@StefanKarpinski
Copy link
Member

In #107 the tests for throwing EOFError when a tarball is truncated were made significantly more systematic, which revealed that we don't always when we should. This should be fixed. I merged that PR with broken tests because not throwing errors for a truncated tarball isn't that big an issue and I wanted to get on with other things, but this should be fixed at some point. Note that the test-set for a truncated header is disabled for Julia 1.3; it's unclear whether these tests were failing due to a Julia bug that was fixed or not. It would be good to understand that issue as well.

@StefanKarpinski StefanKarpinski added the bug Something isn't working label Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant