Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat updates #241

Merged
merged 1 commit into from
Nov 30, 2023
Merged

compat updates #241

merged 1 commit into from
Nov 30, 2023

Conversation

jaakkor2
Copy link
Contributor

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (507c6b6) 92.34% compared to head (1cb34b7) 92.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
- Coverage   92.34%   92.34%   -0.01%     
==========================================
  Files          25       25              
  Lines        2808     2807       -1     
==========================================
- Hits         2593     2592       -1     
  Misses        215      215              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaakkor2
Copy link
Contributor Author

Seems to pass on latest and fail on nightly.

@jaakkor2
Copy link
Contributor Author

Failing on nightly is not related to this PR.

@Drvi
Copy link
Member

Drvi commented Nov 30, 2023

Thanks, @jaakkor2, I'll look into the issues on nightly.

@Drvi Drvi merged commit 40ad044 into JuliaIO:master Nov 30, 2023
6 of 10 checks passed
@jaakkor2 jaakkor2 deleted the compatupdate branch November 30, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants