Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve comments in output _pb.jl files from original .proto #208

Open
NHDaly opened this issue Aug 18, 2022 · 0 comments
Open

Preserve comments in output _pb.jl files from original .proto #208

NHDaly opened this issue Aug 18, 2022 · 0 comments

Comments

@NHDaly
Copy link

NHDaly commented Aug 18, 2022

We should ideally copy all the comments from the original .proto file into the new generated _pb.jl file by reading the comments fields off of the SourceCodeInfo proto.

An example that does this in Go can be found here (under the MIT license):
https://github.com/pseudomuto/protokit/blob/7037620/comments.go


This issue is extracted from #128, which was never merged, and is obsolete after the 1.0.0 rewrite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant