Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using internal functions from CodecBzip2 #1183

Open
nhz2 opened this issue Dec 17, 2024 · 1 comment
Open

Using internal functions from CodecBzip2 #1183

nhz2 opened this issue Dec 17, 2024 · 1 comment

Comments

@nhz2
Copy link
Member

nhz2 commented Dec 17, 2024

For example:

ret = CodecBzip2.decompress_init!(stream, 0, false)

decompress_init! is not part of CodecBzip2's API and is not documented or tested in CodecBzip2, so using it here may break any time CodecBzip2 is updated.

@mkitti
Copy link
Member

mkitti commented Dec 17, 2024

These are basically direct translations from C, so perhaps it would be better to depend on the JLLs directly rather than the light wrappers in the codec packages.

However, my hope is that we could eventually replace these direct ports from C with implementations using TranscodingStreams.jl API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants