Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WARNING: both GeometryOps and Base export "contains" #20

Open
alex-s-gardner opened this issue Oct 2, 2023 · 1 comment
Open

WARNING: both GeometryOps and Base export "contains" #20

alex-s-gardner opened this issue Oct 2, 2023 · 1 comment

Comments

@alex-s-gardner
Copy link
Contributor

I'm not sure how others typically deal with this but does this mean that GeometryOps should not export contains or GeometryOps needs to add a method to Base.contains?
@rafaqz
Copy link
Member

rafaqz commented Oct 3, 2023

Yeah it just shouldnt be exported.

It cant be Base.contains because the semantics are specific to spatial data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rafaqz @alex-s-gardner