Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont print info by default #45

Open
KristofferC opened this issue Sep 24, 2018 · 3 comments
Open

Dont print info by default #45

KristofferC opened this issue Sep 24, 2018 · 3 comments

Comments

@KristofferC
Copy link

KristofferC commented Sep 24, 2018

It would be nice if there was a verbose option to turn on the info-printing but have it be quiet by default.

@ahojukka5
Copy link
Member

What about if we change those to debug? In a bigger picture, we should have some kind of logging system so that we can write messages to log files. Also, it would be nice to control the number of logging messages based on that is user executing functions interactively in REPL or running them from the script file.

@KristofferC
Copy link
Author

Debug probably also works, but I am not very familiar with the Base Logging system.

@benzwick
Copy link
Collaborator

I agree that changing these messages to debug is a good idea. Maybe leave the warnings as they are though (or change those to info if they are not very important).

If a user wants to write messages to log files they can easily substitute the base logging with e.g. Memento. This means we can continue to use base logging and let users decide what they want to do with their logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants