Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make individual commits for different deprecations? #45

Open
StefanKarpinski opened this issue Sep 29, 2017 · 3 comments
Open

make individual commits for different deprecations? #45

StefanKarpinski opened this issue Sep 29, 2017 · 3 comments

Comments

@StefanKarpinski
Copy link
Member

This seems like it would make deprecation fix PRs much easier to review and it would be possible to ask FemtoCleaner to drop individual kinds of deprecation changes by commenting on the appropriate commit. This would also make its commit messages considerably more informative.

@KristofferC
Copy link
Contributor

I think this is a bit difficult to do because the all the deprecations fixes are run and if two deprecations want to fix overlapping source code, one of them is applied and the deprecations are run again until convergence. I think that makes it a bit hard to separate them into individual commits.

@StefanKarpinski
Copy link
Member Author

Can't you just apply each one until convergence?

@KristofferC
Copy link
Contributor

Perhaps, I'll experiment a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants