New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect bot action in invenia/Memento.jl #110

Open

femtocleaner bot opened this issue Feb 21, 2019 · 1 comment

femtocleaner bot commented Feb 21, 2019

@ararslan has indicated an incorrect bot action in invenia/Memento.jl#110
The relevant snippets are shown below:

@@ -78,7 +78,7 @@ mutable struct EC2Record <: Record
         trace = Attribute{StackTrace}(get_trace)
 
         EC2Record(
-            Attribute{DateTime}(() -> round(time, Dates.Second)),
+            Attribute{DateTime}(() -> round(time, digits=Dates.Second)),

@@ -98,7 +98,7 @@ mutable struct CSVFormatter <: Formatter
     delim::Char
     vals::Array{Symbol}
 
-    CSVFormatter(delim=',', vals=Array{Symbol}()) = new(delim, vals)
+    CSVFormatter(delim=',', vals=Array{Symbol}(undef)) = new(delim, vals)

cormullion commented Mar 26, 2019

I had the round() one today, in cormullion/TickTock.jl#1 . But you already know about it, don't you femtocleaner? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment