Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create error for local G* if self included is missing #16

Open
JosiahParry opened this issue Apr 30, 2022 · 1 comment
Open

Create error for local G* if self included is missing #16

JosiahParry opened this issue Apr 30, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@JosiahParry
Copy link
Owner

When the self isnt included it is added and weights are recalculated. It makes the assumption of queen weights. This isn't fair.
Instead, it should error out and inform the user that self.included is missing and that it should be added with included_self(nb) and then calculate weights

if (is.null(attr(nb, "self.included"))) {

@JosiahParry JosiahParry added the good first issue Good for newcomers label Apr 30, 2022
@JosiahParry JosiahParry reopened this May 25, 2022
@opelolo
Copy link
Contributor

opelolo commented Aug 5, 2022

Hello @JosiahParry please will you kindly assign this to me as well? I'd like to try it if it's still available. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants