Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove installDeps #227

Open
milesfrain opened this issue Aug 26, 2020 · 0 comments
Open

Remove installDeps #227

milesfrain opened this issue Aug 26, 2020 · 0 comments
Labels
cookbook Issues related to this repo as a whole and not a recipe in particular

Comments

@milesfrain
Copy link
Collaborator

This step was leftover from when we used pnpm.

purescript-cookbook/makefile

Lines 93 to 98 in 1d3ede9

# Downloads all dependencies and sets up cookbook, so that end-user doesn't
# accidentally use `npm`.
.PHONY: installDeps
installDeps:
> npm i
> rm package-lock.json

Proposing:

  • Remove installDeps from makefile
  • Add package-lock.json to .gitignore
  • Update readmes to mention npm i for installing dependencies locally.
@milesfrain milesfrain added the cookbook Issues related to this repo as a whole and not a recipe in particular label Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cookbook Issues related to this repo as a whole and not a recipe in particular
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@milesfrain