Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup header and triggers. #112

Open
mholtrop opened this issue Jul 2, 2020 · 0 comments
Open

Cleanup header and triggers. #112

mholtrop opened this issue Jul 2, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@mholtrop
Copy link
Collaborator

mholtrop commented Jul 2, 2020

The header currently carries the trigger information that is only useful for 2016 data and stores those bits as "int".
The 2019 trigger data is in TSData, which has an incorrectly translated struct which is no longer a bitwise struct and contains an "unsigned int NA" and "unsigned int intval". The "intval" should be in a union with the bitwise struct.

Plan:
Make the header independent of the data set.
Make a new class for the 2016 trigger data.
Cleanup and make useful the TSData and VTPData banks for 2019.
Add methods to the EventHeader to retrieve trigger information in a uniform manner.

@mholtrop mholtrop added the enhancement New feature or request label Jul 2, 2020
@mholtrop mholtrop self-assigned this Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant