Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Module Import Logic #1482

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Enhance Module Import Logic #1482

wants to merge 4 commits into from

Conversation

AshishMahendra
Copy link
Collaborator

Description

This PR refines the run_import method to improve the module import process for Jac files. Key improvements include:

Enhanced Search Path Resolution:

  • The method effectively incorporates JACPATH and the caller directory to locate modules.
  • Handles both directory modules and .jac files with improved checks.

@AshishMahendra AshishMahendra linked an issue Dec 9, 2024 that may be closed by this pull request
A suggestion for cleaner jac imports #1409
Open
@ChrisIsKing
Copy link
Collaborator

Tested and works fine.

@AshishMahendra I'm good to merge once we fix the error logging when searching the relative path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marsninja marsninja

@ChrisIsKing ChrisIsKing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A suggestion for cleaner jac imports
4 participants
@AshishMahendra @ChrisIsKing @marsninja @kugesan1105