Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

[FEATURE] Support Rebuilding Edited Files in Workspace #297

Open
musab-mah-7 opened this issue Mar 21, 2024 · 1 comment
Open

[FEATURE] Support Rebuilding Edited Files in Workspace #297

musab-mah-7 opened this issue Mar 21, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@musab-mah-7
Copy link
Collaborator

Description:
Currently, the rebuild_file method in our VS Code extension only supports rebuilding saved files using the file_path parameter. However, there's a need to support rebuilding files that are being actively edited within the workspace. This limitation affects the usability and functionality of the extension, especially in scenarios where users are making changes to files but need to trigger a rebuild without saving them first.

Proposal:

  • Enhance the rebuild_file method to support rebuilding files currently open and being edited in the workspace.
  • Provide support for passing the source code directly to the method instead of relying solely on file paths.

Eg:

`
def rebuild_file(self, file_path: str, deep: bool = False, source:str ="") -> bool:

    if (source == "") :
        with open(file_path, "r") as f:
            source = f.read()        
    build = jac_str_to_pass(
        jac_str=source,
        file_path=file_path,
        schedule=py_code_gen_typed,
    )

`

This enhancement would greatly improve the workflow for users of our extension, enabling them to trigger rebuilds more efficiently and effectively. Additionally, it aligns with the expectations of users who rely on such functionality within integrated development environments like VS Code.

@musab-mah-7 musab-mah-7 added the enhancement New feature or request label Mar 21, 2024
@Sivasuthan9
Copy link
Collaborator

Sivasuthan9 commented Mar 21, 2024

Updated @marsninja , pr : #298

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants