From cc659a9b4de58a4d1852e08d1865842558ce1245 Mon Sep 17 00:00:00 2001
From: Jan <125610144+Jongjan88@users.noreply.github.com>
Date: Tue, 26 Mar 2024 22:04:38 +0100
Subject: [PATCH] warn if a newly created wallet is legacy

---
 src/wallet/wallet.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
index 4ab5c6a3b6..cbf78a68c6 100644
--- a/src/wallet/wallet.cpp
+++ b/src/wallet/wallet.cpp
@@ -342,6 +342,11 @@ std::shared_ptr<CWallet> CreateWallet(interfaces::Chain& chain, const std::strin
     // Write the wallet settings
     UpdateWalletSetting(chain, name, load_on_start, warnings);
 
+    // Legacy wallets are being deprecated, warn if a newly created wallet is legacy
+    if (!(wallet_creation_flags & WALLET_FLAG_DESCRIPTORS)) {
+        warnings.push_back(_("Wallet created successfully. The legacy wallet type is being deprecated and support for creating and opening legacy wallets will be removed in the future."));
+    }
+
     status = DatabaseStatus::SUCCESS;
     return wallet;
 }